RFC Errata


Errata Search

 
Source of RFC  
Summary Table Full Records

RFC 5905, "Network Time Protocol Version 4: Protocol and Algorithms Specification", June 2010

Note: This RFC has been updated by RFC 7822, RFC 8573, RFC 9109

Source of RFC: ntp (int)

Errata ID: 6280
Status: Held for Document Update
Type: Technical
Publication Format(s) : TEXT

Reported By: Jingguo Yao
Date Reported: 2020-09-05
Held for Document Update by: Erik Kline
Date Held: 2022-09-26

Section A.5.5.1. says:

There is the following comment:

* First, construct the chime list of tuples (p, type, edge) as
* shown below, then sort the list by edge from lowest to
* highest.


It should say:

There should be some statements to do the sorting since the comment mentions it. But there are no statements related to sorting in the following code. 

And I checked the NTP reference implementation. There is code to do the sorting at https://github.com/ntp-project/ntp/blob/71a962710bfe066f76da9679cf4cfdeffe34e95e/ntpd/ntp_proto.c#L2837

Notes:

From https://mailarchive.ietf.org/arch/msg/ntp/zJNoHvZ08SPX-3kwflMK7PIReFo/ :

"""
... correctly identifies the problem, but it doesn't provide the new
text. I'd suggest to add "sort(s.m, n);" right after the first while
loop in A.5.5.1.
"""

Report New Errata



Advanced Search